Hello all,

I have searched the forum for my following question but could not find a thread about it (please tell me if there is)

While things are going really good with my Blog , it seems that the space on my server is becoming rather spare . I looked at all the large images, moved them elsewhere on the net, but also found 111 kb of pop-up files.

My Uploaded Pop-up Image Template uses, as all other templates, PHP files. When I look inside the generated files, the only 3 differences between them are the URL of the image, its width and its height.

This does not seem a very smart way of coding, would somebody have a better way (PHP?) to make pop-ups with only ONE file for all images?

(or maybe even without a separate file at all?)

You could use a template file and pass the variables through with PHP--use a GET or POST, with variables like:



And then in the template, you'd have it open $file with $width and $height.

You could also do something with a Javascript function...

openPopup(filename,width,height)
{code}

and then in the link, you would just do onClick=openPopup(myfile.jpg,800,600).

Thank you gramcracker (and girlie?),
that puts me in the right direction, but
(there seems to always be a but...)

The pop-up code is somewhat more complicated to make a link work with a browser without javascript, I made it with your advise to the following:

And for some reason this does not work.

I used in the popup.php the following line:

is that correct?

What happens is that the window gets closed without showing any pop-up.

Lawrence

Hmmm.  Try taking it apart a step at a time.

First try doing the popup just as a javascript-enabled link, so you can figure out if it's the javascript code that's not working, or the PHP.  When the popup.php opens, check the source code.  Are the variables filled in as they should be?

Also, try getting rid of the window.close() stuff.  See if that's making it hiccup.

Simplify it down, and then see if you get anywhere.

Aha, it works. Still not perfectly, but this is a matter of tweaking.

simplified the call to


And corrected the fault in above mentioned frase of the popup.php:


Thanks for your support!
Lawrence