Movable Type Community Forum > MT 2.66 and XHTML bug

Movable Type Community Forum > Other Product Discussion > Bugs and Odd Behavior

distler

Jan 14 2004, 08:50 PM

MT 2.66 turns URLs in comments into redirects. Unfortunately, the existing code fails miserably if you are serving your pages as application/xhtml+xml. Here's a patch to fix it (see also my blog entry).

arvind

Jan 14 2004, 09:23 PM

what exaclty are u meant to do with this patch where does it go ?

distler

Jan 14 2004, 09:41 PM

From the commandline, in the main MT directory,

CODE

patch < 2.66.patch

or you could apply the changes by hand, by editing lib/MT/App/Comments.pm.

Of course, if you are not sending your pages as application/xhtml+xml, the original code will work fine.

75th Trombone

Jan 14 2004, 10:48 PM

Another problem: The redirect URLs are invalid themselves. They use straight ampersands instead of & entities.

Which script writes these URLs, so it can be fixed?

SFT

Jeroen Sangers

Jan 15 2004, 08:01 AM

Have a look at lib/MT/Template/Context.pm, around line 1189. I changed this line, and my site produces valid HTML again.

See also MT update breaks validation

distler

Jan 15 2004, 02:32 PM

Yeah, I "revised" my patch above to include both fixes in the same patch file. (I previously had them in two separate files.)

TweezerMan

Jan 15 2004, 02:51 PM

Six Apart has released an update (MT 2.661) that fixes the invalid XHTML in the redirect URL.

distler

Jan 15 2004, 03:51 PM

But no the other issue.

So, back to my original patch (to lib/MT/App/Comments.pm alone).

distler

Jan 16 2004, 12:18 AM

Alas, 2.661 still does not produce valid XHTML in the Comment-Preview window. The problem is that a comment being previewed does not yet have a CommentID.

This fixes the problem:

CODE

--- lib/MT/Template/Context.pm.orig Thu Jan 15 14:36:13 2004
+++ lib/MT/Template/Context.pm Thu Jan 15 17:33:55 2004
@@ -1184,7 +1184,7 @@
my $cgi_path = MT::ConfigMgr->instance->CGIPath;
$cgi_path =~ s#([^/])$#$1/#;
my $comment_script = MT::ConfigMgr->instance->CommentScript;
- return sprintf(qq(<a target="_blank" href="%s%s?__mode=red&id=%d">%s</a>),
+ if($c->id){
+ return sprintf(qq(<a href="%s%s?__mode=red&id=%d">%s</a>),
$cgi_path, $comment_script, $c->id, $name);
+ } else {
+ return sprintf(qq(<a href="%s">%s</a>), $c->url, $name);
+ }
} elsif ($show_email && $c->email) {
my $email = remove_html($c->email);

I folded this into the patch file mentioned above (which now applies to 2.661).

cobra libre

Jan 16 2004, 05:03 PM

Thanks for coming up with a fix so quickly, Jacques.

One tiny thing: The patch you posted for 2.661 on this page needs to be changed so that the ampersand in the line

CODE

return sprintf(qq(<a href="%s%s?__mode=red&id=%d">%s</a>),

is escaped.

distler

Jan 16 2004, 06:10 PM

Thanks for the catch. I edited the comment appropriately.

This is a "lo-fi" version of our main content. To view the full version with more information, formatting and images, please click here.